Remove the url crate dep from payjoin-test-utils#1111
Merged
DanGould merged 1 commit intopayjoin:masterfrom Sep 25, 2025
Merged
Remove the url crate dep from payjoin-test-utils#1111DanGould merged 1 commit intopayjoin:masterfrom
DanGould merged 1 commit intopayjoin:masterfrom
Conversation
benalleng
force-pushed
the
remove-test-utils-url-and-request
branch
from
569e1e8 to
dd4c373
Compare
Collaborator
Pull Request Test Coverage Report for Build 18014757645Details
💛 - Coveralls |
benalleng
force-pushed
the
remove-test-utils-url-and-request
branch
3 times, most recently
from
3eaa107 to
06090bf
Compare
DanGould
requested changes
Sep 25, 2025
Contributor
DanGould
left a comment
DanGould
left a comment
There was a problem hiding this comment.
YES! nice net deletion. I did note one place Url was being used redundantly.
| var proposal = res.inner; | ||
| return await process_unchecked_proposal( | ||
| proposal, recv_persister); | ||
| return await process_unchecked_proposal(proposal, recv_persister); |
Contributor
There was a problem hiding this comment.
noting that this is just a lint
payjoin-test-utils/src/lib.rs
Outdated
Comment on lines
236
to
238
| let health_url: Url = format!("{}/health", service_url.trim_end_matches("/")) | ||
| .parse() | ||
| .map_err(|_| "Invalid Url")?; |
Contributor
There was a problem hiding this comment.
Suggested change
| let health_url: Url = format!("{}/health", service_url.trim_end_matches("/")) | |
| .parse() | |
| .map_err(|_| "Invalid Url")?; | |
| let health_url = format!("{}/health", service_url.trim_end_matches("/")); |
Because the fn get type signature takes U: IntoUrl and From<String> for [reqwest::]IntoUrl is implemented.
reqwest::async_impl::client::Client
pub fn get<U>(&self, url: U) -> RequestBuilder
where
U: IntoUrl,
benalleng
force-pushed
the
remove-test-utils-url-and-request
branch
4 times, most recently
from
c5c7e6f to
1b3d976
Compare
Contributor
|
gah, conflict |
This removes the url crate completely and replaces it with Strings where appropriate. Notably we still use `reqest::Url` in the `wait_for_services_ready` function.
benalleng
force-pushed
the
remove-test-utils-url-and-request
branch
from
1b3d976 to
6ebeec8
Compare
DanGould
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the url crate completely and replaces it with Strings where appropriate. Notably we still use
rewqest::Urlin thewait_for_services_readyfunction.In the payjoin crate we have not yet removed the Url so we need to parse the EXAMPLE_URL in some tests.
checks some boxes in #513
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.