Skip to content

Reduce visibility of common recv abstractions#1109

Merged
arminsabouri merged 1 commit intopayjoin:masterfrom
arminsabouri:reduce-vis-recv-common
Sep 24, 2025
Merged

Reduce visibility of common recv abstractions#1109
arminsabouri merged 1 commit intopayjoin:masterfrom
arminsabouri:reduce-vis-recv-common

Conversation

@arminsabouri
Copy link
Collaborator

Change visibility of common receiver abstractions to pub(super). Only the parent receiver module should have access to the common abstractions.

Pull Request Checklist

Please confirm the following before requesting review:

Change visibility of common receiver abstractions to `pub(super)`. Only
the parent receiver module should have access to the common
abstractions.
@arminsabouri arminsabouri self-assigned this Sep 24, 2025
Copy link
Contributor

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arminsabouri perseveres. YTB

ACK 626f72a

will merge assuming CI passes.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17981356711

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.525%

Totals Coverage Status
Change from base Build 17960911092: 0.0%
Covered Lines: 8581
Relevant Lines: 10152

💛 - Coveralls

@arminsabouri arminsabouri merged commit 0efe636 into payjoin:master Sep 24, 2025
10 checks passed
@arminsabouri arminsabouri deleted the reduce-vis-recv-common branch September 24, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants