Skip to content

Use "expiration" instead of "expiry"#1087

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
arminsabouri:rename-expiration
Sep 17, 2025
Merged

Use "expiration" instead of "expiry"#1087
spacebear21 merged 1 commit intopayjoin:masterfrom
arminsabouri:rename-expiration

Conversation

@arminsabouri
Copy link
Collaborator

Our codebase goes back and forth between "expiry" and "expiration". Expiry is prefered as its used in BIP-77.

Closes: #1065

Pull Request Checklist

Please confirm the following before requesting review:

Our codebase goes back and forth between "expiry" and "expiration".
Expiry is prefered as its used in BIP-77.
@arminsabouri arminsabouri self-assigned this Sep 17, 2025
@arminsabouri arminsabouri added this to the payjoin-1.0 milestone Sep 17, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17803250787

Details

  • 33 of 34 (97.06%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 84.681%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin/src/core/send/v2/error.rs 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
payjoin/src/core/receive/v2/mod.rs 1 92.4%
Totals Coverage Status
Change from base Build 17782565042: 0.003%
Covered Lines: 8082
Relevant Lines: 9544

💛 - Coveralls

Copy link
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e5e548c

@spacebear21 spacebear21 merged commit 5cce5db into payjoin:master Sep 17, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

terminology: use "expiration" instead of "expiry" consistently with spec

3 participants