Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-384: Do not activate if definition-bearing bean is disabled #80

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

pdudits
Copy link
Contributor

@pdudits pdudits commented Apr 14, 2021

Previous refactorings weren't able to respect when a bean with OpenId definition annotation was disabled. So the mechanics of extension bootstrap circled back to something similar what previous extension did, just with more recent API.

Standalone library works on Server with this, Micro doesn't have that much luck.

@pdudits pdudits requested a review from Cousjava April 14, 2021 08:46
pdudits added 2 commits April 14, 2021 15:27
When using standalone connector as a library in Micro the deployment fails
with

Unsatisfied dependencies for type IdentityStoreHandler with qualifiers @default
  at injection point [UnbackedAnnotatedField] @Inject @default private .OpenIdAuthenticationMechanism.identityStoreHandler

To workaround that, place a producer in the app:

@ApplicationScoped
class Workaround {
    @Inject
    IdentityStoreHandler handler;

    @produces
    @InjectionWorkaround
    @ApplicationScoped
    IdentityStoreHandler reexport() {
        return handler;
    }
}

Mechanism will use standard IdentityStoreHandler when it is available and then
resort to workaround.
@pdudits pdudits merged commit beb214c into master Apr 14, 2021
@pdudits pdudits deleted the cloud-463 branch April 14, 2021 14:03
@jGauravGupta jGauravGupta added this to the 2.0.0.beta1 milestone May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants