Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish 383 working oauth for azure ad b2c #147

Merged
merged 2 commits into from
Nov 19, 2021

Conversation

aubi
Copy link
Contributor

@aubi aubi commented Nov 18, 2021

Make the @OpenIdAuthenticationDefinition working also for Azure AD B2C, basically make parsing of expires_in more tolerant, expected number but provided a string.
Reproducing application is attached to the Jira ticket.

@OpenIdAuthenticationDefinition(
        providerURI = "https://login.microsoftonline.com/${APP_ID}/",
        providerMetadata = @OpenIdProviderMetadata(
                // MS "supports" only openid, others fail validation
                scopesSupported = {"email", "profile", "openid"}
        ),
        clientId = "${CLIENT_ID}",
        clientSecret = "{CLIENT_SECRET}",
        redirectURI = "${baseURL}/callback",
        logout = @LogoutDefinition(notifyProvider = true, redirectURI = "http://localhost:8080/OpenIdReproducer/"),
        // long enough timeouts to be sure
        jwksConnectTimeout = 2_000,
        jwksReadTimeout = 2_000
)

Both Login and logout work well.

@aubi aubi requested a review from pdudits November 18, 2021 14:19
@aubi aubi force-pushed the FISH-383-working-oauth-for-azure-ad-b2c branch from 43a2184 to 53be99a Compare November 18, 2021 14:24
@aubi aubi force-pushed the FISH-383-working-oauth-for-azure-ad-b2c branch from 53be99a to 2c65ecd Compare November 18, 2021 14:48
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aubi aubi merged commit ccdeb06 into payara:master Nov 19, 2021
@aubi aubi deleted the FISH-383-working-oauth-for-azure-ad-b2c branch November 19, 2021 08:10
JamesHillyard pushed a commit to JamesHillyard/ecosystem-security-connectors that referenced this pull request Jan 21, 2022
…ure-ad-b2c

Fish 383 working oauth for azure ad b2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants