Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fish 5742 subject type supported metadata #144

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Fish 5742 subject type supported metadata #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97204a6
FISH-5742 remove invalid check of subject types supported
Nov 11, 2021
e04e0ca
FISH-5742 add comment in annotation, subjectTypesSupported is not used
Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions openid/src/main/java/fish/payara/security/openid/controller/ConfigurationController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,9 +318,6 @@ private List<String> validateProviderMetadata(OpenIdConfiguration configuration)
if (configuration.getProviderMetadata().getResponseTypesSupported().isEmpty()) {
errorMessages.add("response_types_supported metadata is mandatory");
}
if (configuration.getProviderMetadata().getResponseTypesSupported().isEmpty()) {
errorMessages.add("subject_types_supported metadata is mandatory");
}
if (configuration.getProviderMetadata().getIdTokenSigningAlgValuesSupported().isEmpty()) {
errorMessages.add("id_token_signing_alg_values_supported metadata is mandatory");
}
Expand Down
3 changes: 2 additions & 1 deletion ...connectors-api/src/main/java/fish/payara/security/annotations/OpenIdProviderMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@
// OPTIONAL. List of the Authentication Context Class References that this OP supports.
//
/**
* Required: List of the Subject Identifier types that this OP supports. Valid types include pairwise and public.
* Required by standard, but not used by Payara for now: List of the Subject Identifier types that this OP supports.
* Valid types include pairwise and public.
*
* To set this using Microprofile Config use {@code payara.security.openid.provider.subjectTypesSupported}
*
Expand Down