-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FISH-5743 FISH-5741 define oicd metadata locally #138
Merged
aubi
merged 8 commits into
payara:master
from
aubi:FISH-5743-define-oicd-metadata-locally
Nov 11, 2021
Merged
FISH-5743 FISH-5741 define oicd metadata locally #138
aubi
merged 8 commits into
payara:master
from
aubi:FISH-5743-define-oicd-metadata-locally
Nov 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubi
changed the title
Fish 5743 FISH-5741 define oicd metadata locally
FISH-5743 FISH-5741 define oicd metadata locally
Nov 9, 2021
User can now bypass autoconfiguration from .well-know address to fill openid client metadata in @OpenIdProviderMetadata.
aubi
force-pushed
the
FISH-5743-define-oicd-metadata-locally
branch
from
November 9, 2021 17:09
e146365
to
738cf37
Compare
OndroMih
approved these changes
Nov 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve. I only left a few comments for rather cosmetic improvements, none of them are needed to merge this PR.
openid/src/main/java/fish/payara/security/openid/controller/ConfigurationController.java
Outdated
Show resolved
Hide resolved
openid/src/main/java/fish/payara/security/openid/controller/ProviderMetadataContoller.java
Outdated
Show resolved
Hide resolved
openid/src/main/java/fish/payara/security/openid/controller/ProviderMetadataContoller.java
Outdated
Show resolved
Hide resolved
openid/src/main/java/fish/payara/security/openid/controller/ProviderMetadataContoller.java
Outdated
Show resolved
Hide resolved
No functional change, code style after review.
OndroMih
approved these changes
Nov 11, 2021
JamesHillyard
approved these changes
Nov 11, 2021
JamesHillyard
pushed a commit
to JamesHillyard/ecosystem-security-connectors
that referenced
this pull request
Jan 21, 2022
…a-locally FISH-5743 FISH-5741 define oicd metadata locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance @OpenIdProviderMetadata with all necessary metadata to skip autoconfiguration as is currently supported by providerURI.
Reproducer is attached to the Jira issue FISH-5741.
Basically, the configuration can provide information this way:
How to test
In Payara, pom.xml update security connectors to snapshot:
<payara.security-connectors.version>2.2.0-SNAPSHOT</payara.security-connectors.version>
Deploy sample app, login.
Try to comment providerURI, providerMetadata and payara.security.openid.provider.issuer in microprofile-config.properties. This fails with exception complaining issuer is required.
Try to uncomment each option, any of the will work.