Merge pull request #144 from aubi/FISH-5742-subject-type-supported-me…

…tadata Fish 5742 subject type supported metadata
payara · Nov 15, 2021 · 2ce4e47 · 2ce4e47
2 parents 353b25c + e04e0ca
commit 2ce4e47
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/openid/src/main/java/fish/payara/security/openid/controller/ConfigurationController.java b/openid/src/main/java/fish/payara/security/openid/controller/ConfigurationController.java
@@ -318,9 +318,6 @@ private List<String> validateProviderMetadata(OpenIdConfiguration configuration)
         if (configuration.getProviderMetadata().getResponseTypesSupported().isEmpty()) {
             errorMessages.add("response_types_supported metadata is mandatory");
         }
-        if (configuration.getProviderMetadata().getResponseTypesSupported().isEmpty()) {
-            errorMessages.add("subject_types_supported metadata is mandatory");
-        }
         if (configuration.getProviderMetadata().getIdTokenSigningAlgValuesSupported().isEmpty()) {
             errorMessages.add("id_token_signing_alg_values_supported metadata is mandatory");
         }

diff --git a/...connectors-api/src/main/java/fish/payara/security/annotations/OpenIdProviderMetadata.java b/...connectors-api/src/main/java/fish/payara/security/annotations/OpenIdProviderMetadata.java
@@ -156,7 +156,8 @@
     //    OPTIONAL. List of the Authentication Context Class References that this OP supports.
     //
     /**
-     * Required: List of the Subject Identifier types that this OP supports. Valid types include pairwise and public.
+     * Required by standard, but not used by Payara for now: List of the Subject Identifier types that this OP supports.
+     * Valid types include pairwise and public.
      *
      * To set this using Microprofile Config use {@code payara.security.openid.provider.subjectTypesSupported}
      *