FISH-5703 Option to Improve Logging Speed #5493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
|
Jenkins test please |
rdebusscher
suggested changes
Nov 8, 2021
nucleus/common/common-util/src/main/java/com/sun/common/util/logging/GFLogRecord.java
Outdated
Show resolved
Hide resolved
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
|
Jenkins test please |
|
Jenkins test please |
aubi
approved these changes
Nov 24, 2021
rdebusscher
approved these changes
Nov 24, 2021
aubi
pushed a commit
to aubi/Payara
that referenced
this pull request
Jan 3, 2022
FISH-5703 Option to Improve Logging Speed
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Jan 24, 2022
FISH-5703 Option to Improve Logging Speed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new feature allowing users to skip the forced .toString() on all parameters when logging. The command to set this property has been added to set-log-attributes and the admin console. This property is updated dynamically and doesn't need a server restart for the logging changes to take affect.
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Manually tested the toString is skipped appropriately and without the need for a server restart. Ran the logging tests already in place.
Testing Environment
Windows 10, JDK 8, Maven 3.6.3
Documentation
Community Documentation PR: payara/Payara-Community-Documentation#276
Notes for Reviewers
If you test this manually, fastLoggingEnabled() will return the old value while logging a logging property has been changed. Any logs after this will be using the new value. This doesn't impact the functionality but please keep it in mind if you manually test.