FISH-5686 Log warning when not running on a supported (LTS) JDK version #5417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
JamesHillyard
requested review from
rdebusscher,
Pandrex247 and
jGauravGupta
|
Jenkins test please |
|
Missing some portions copyright headers. |
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
|
Jenkins test please |
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
FISH-5686 Log warning when not running on a supported (LTS) JDK version Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-5686 Log warning when not running on a supported (LTS) JDK version
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 23, 2021
This reverts commit a8d79cc.
aubi
pushed a commit
to aubi/Payara
that referenced
this pull request
Jan 3, 2022
FISH-5686 Log warning when not running on a supported (LTS) JDK version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the current JDK checks to be up to date, checking the user is running an LTS JDK version. If they aren't a message will be printed in the console and a warning will be present in the logs, even if the Admin Console failed to start. A warning is also printed for Micro on startup (See images below)
Important Info
Testing
Testing Performed
Programmatically tested the logic works for the correct JDK versions. Manually tested the warnings are shown where appropriate.
Testing Environment
Windows 10 Pro, JDK8/9, Maven 3.6.3
Documentation
No documentation needed.
Notes for Reviewers
Starting the domain on JDK9
Admin Console warning
Payara Micro on Startup
