FISH-376 Allow finer configuration details of HTTP GZIP compression #5407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
|
Jenkins test please Edit: This won't be able to be tested in Jenkins until the PR in patched-src-grizzly has been merged. |
|
Do we need a newer version of our Patched Grizzly? no pom.xml changes. |
Pandrex247
approved these changes
Sep 13, 2021
nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/GenericGrizzlyListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
|
Jenkins test please |
jGauravGupta
approved these changes
Sep 16, 2021
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-376 Allow finer configuration details of HTTP GZIP compression
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Dec 23, 2021
This reverts commit 48d861f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An improvement allowing finer configuration of HTTP GZip Compression. It allows the user to configure between three compression strategies: Default, Filtered and Huffman Only.
It also allows for setting the compression level, -1 is the default level, 0 is no compression, 1 is fastest speed and 9 is fastest compression.
Changes have also been made in patched-src-grizzly: payara/patched-src-grizzly#31
Important Info
Blockers
Requires PR in patched-src-grizzly to be merged.
Testing
New tests
CompressionTest in Payara samples. Tests compression in all strategies and levels works.
Testing Performed
Manually tested compression works with:
curl http://localhost:8080 --silent -H "Accept-Encoding: gzip,deflate" --write-out "%{size_download}\n" --output /dev/null
Tested using the new test in Payara Samples.
Testing Environment
Windows 10 Pro, Maven 3.6.3, JDK8
Documentation
Documentation PR: payara/Payara-Community-Documentation#246
Notes for Reviewers
Changes have also been made in
The new setting look like the following image under Network Config -> Network Listeners -> {Listener} -> HTTP