Skip to content

Consistency overhaul #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 106 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
d1ae325
Consistency improvements:
Y-Less Apr 27, 2021
c151017
Revert callback name changes because the compiler is picky about them.
Y-Less Apr 27, 2021
8bad002
More `camelCase` parameter names.
Y-Less Apr 27, 2021
78ef1ca
`id` -> `ID`
Y-Less Apr 27, 2021
35e40a9
Revert forwards again.
Y-Less Apr 27, 2021
c37b66d
`ID` is bad...
Y-Less Apr 27, 2021
e3584e1
More tweaks:
Y-Less Apr 27, 2021
6ec7e5f
Idiomatic DB function naming.
Y-Less Apr 27, 2021
a41db32
Name tweaks.
Y-Less May 4, 2021
04ca6ac
Fix clobbered names.
Y-Less May 4, 2021
2fa5a19
Another tag and name clobber.
Y-Less May 4, 2021
c5b0181
More tags.
Y-Less Oct 3, 2018
5e45fae
More enums.
Y-Less May 8, 2021
a14dace
Lost a load of commits due to repo corruption:
May 9, 2021
fc55463
More correct tag syntax.
May 9, 2021
1c03741
Callback tags.
May 9, 2021
3704e48
Document progressive tag enhancement.
May 9, 2021
cf78bdb
List of all updated callbacks.
May 9, 2021
1d46eb2
`KEY:`.
Y-Less May 11, 2021
e075fb1
Internal enum names.
Y-Less Aug 31, 2021
367be13
Internal enum names.
Y-Less Aug 31, 2021
54eadde
Internal enum names.
Y-Less Aug 31, 2021
32f9805
Internal enum names.
Y-Less Aug 31, 2021
8bd490d
Internal enum names.
Y-Less Aug 31, 2021
7dc15f4
Internal enum names.
Y-Less Aug 31, 2021
5ad1825
Fix a typo in `__SPECTATE_MODE` name.
Y-Less Dec 4, 2021
e13694a
More robust file inclusion/lookup.
Dec 4, 2021
72a0bbd
More definitions.
Dec 4, 2021
6b39b0b
`INVALID_TIMER`.
Dec 4, 2021
1f9f768
Integrate recent PRs.
Dec 4, 2021
6fd3ac2
typo fix: MAX_PLAYER_NAME minimum number.
Dec 18, 2021
51c9d9a
Merge pull request #41 from Kirima2nd/consistency-overhaul
Southclaws Dec 18, 2021
1fcfac3
Sync some defines with a_npc.
Jan 25, 2022
26ebabf
`WEAPON:` tag and `WEAPON_SPLAT` (based on the returned string).
Jan 25, 2022
29fa6fa
Two small camel case fixes.
Jan 29, 2022
b9aa7e9
More parameter renames, and `GPCI`.
Jan 29, 2022
5ebff26
Missing tags.
Jan 29, 2022
2a73ac8
`GetPlayerVehicleid` -> `GetPlayerVehicleID`.
Jan 30, 2022
171bb78
Remove `lenof`.
Jan 31, 2022
f1667df
Spacing fix.
Jan 31, 2022
ebea75e
Rename `CAMERA:` to `CAM_MOVE:` and add `CAM_MODE:`, for less clashy …
Jan 31, 2022
6ffb6a8
Fonts and `centre`.
Jan 31, 2022
7e89741
TD fonts.
Jan 31, 2022
9e17152
`forceSync` isn't a boolean.
Feb 2, 2022
643f3bb
Move readme sections to make more sense.
Y-Less Feb 2, 2022
7927f63
Variable name fix.
Feb 5, 2022
f9d22ce
Fix the pawndoc bug on `print`/`printf`.
Feb 22, 2022
9f1f59f
Switch pawndoc style.
Feb 26, 2022
10fe067
`<library>` header.
Feb 26, 2022
f95bc67
Fix some comment closes.
Feb 26, 2022
994f48c
Fix some comment closes.
Feb 26, 2022
048515f
Add `<library>` identifier to all natives.
Feb 26, 2022
c9a3180
Add `<library>` to some functions without other documentation.
Feb 26, 2022
e9b8955
Fix some inclusions.
Feb 26, 2022
2c1593a
Old-style include guards as well.
Feb 26, 2022
d2b4ee3
You'll prise two space full stops from my cold dead hands!
Feb 26, 2022
af6b7d6
Wrap pawndoc.
Feb 26, 2022
fd0663d
Wrap lines more aggressively.
Feb 26, 2022
054510b
Make the library declaration conditional.
Feb 26, 2022
475a955
Set library on constants.
Feb 27, 2022
1e5a62d
Better constants.
Feb 27, 2022
85b2063
enum documentation
Feb 27, 2022
89e8cf7
Return the correct enum names.
Feb 27, 2022
c885739
Trying to fix the bug.
Feb 27, 2022
3afdb09
Fix pawndoc bugs.
Feb 27, 2022
72c76dd
Add `///` before all enum documentation.
Feb 27, 2022
9c14138
Add `pawndoc.xsl`.
Feb 27, 2022
01a9527
Fix close tag.
Feb 27, 2022
3bcd294
`description=` to `summary=`
Feb 28, 2022
ab9c69e
Switch back to real defines so `#MAX_PLAYERS` etc work correctly. So…
Mar 6, 2022
873c512
Re-enable deprecation warnings.
Mar 6, 2022
bde8012
Fix replacement loop.
Mar 6, 2022
f98c14a
Hide some pawndoc better.
Mar 6, 2022
c8ad7a5
Two missing `a_npc` library tags.
Mar 6, 2022
c335579
Move some player defines around.
Mar 6, 2022
2295182
Separate header comments.
Mar 6, 2022
b0f9fe7
Move some defines to more appropriate files:
Mar 6, 2022
5b3d3a8
Change the include order to resolve some new inter-dependencies.
Mar 6, 2022
72f3957
And match the checks.
Mar 6, 2022
e55f57a
Try fix old a_http includes even more.
Mar 6, 2022
3d89fb0
Add `pawndoc="true"`.
Mar 6, 2022
61501d2
Remove `#define HTTP`.
Mar 7, 2022
5ec4cb3
Move some comments that seemed to cause an issue.
Mar 7, 2022
eff8bfd
Remove empty pawndoc blocks.
Mar 7, 2022
bfb8b6f
`RACECP_TYPE:`
Mar 14, 2022
045fd54
Rename (simplify) the checkpoint tag.
Mar 15, 2022
aafb808
Some more `bool:` return tags.
Mar 16, 2022
2b6b093
Actor `bool:` returns.
Mar 16, 2022
819876e
a_vehicle tags.
Mar 17, 2022
570867e
Another tag.
Mar 17, 2022
92f733a
Make `GetServerVar...` functions aliases for `GetConsoleVar...`.
Mar 18, 2022
2f9dbd3
`__OPEN_MP_VERSION`
Apr 3, 2022
98d7160
More `bool:` return tags.
Apr 8, 2022
bcd211b
More tags
Apr 11, 2022
f058247
Unfortunately callbacks can't have their parameter names changed, so …
Jun 25, 2022
e10ff99
Remove accidental comments from warnings.
Jun 25, 2022
0bf3fc8
Switch strong/weak tag prefixes to `T_`/`t_` - they're less widely us…
Aug 7, 2022
f2d13fd
Move something.
Aug 7, 2022
7b10fd3
`OnPlayerRequestDownload` tag.
Aug 7, 2022
ae862df
Merge remote-tracking branch 'remotes/origin/master' into consistency…
Sep 4, 2022
ceefd22
Back-port weapon slots.
Sep 4, 2022
81ba713
Use weapon slots.
Sep 4, 2022
cf49dbe
More documentation.
Sep 4, 2022
ae3989f
Typo
Sep 4, 2022
c2c58d0
`PLAYER_VARTYPE_`
Sep 4, 2022
8b76202
Prefer `<p/>`
Nov 8, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Unfortunately callbacks can't have their parameter names changed, so …
…we are stuck with `color` in `OnClientMessage`.
  • Loading branch information
Y_Less committed Jun 25, 2022
commit f058247ff469ed246f6fd1df7e11502ee44baba0
4 changes: 2 additions & 2 deletions a_npc.inc
Original file line number Diff line number Diff line change
Expand Up @@ -1073,12 +1073,12 @@ forward OnNPCExitVehicle();
* href="#SendClientMessage">SendClientMessage</a> function is sent towards the NPC. This callback
* won't be called when someone says something. For a version of this with player text, see
* <a href="#OnPlayerText">OnPlayerText</a>.</summary>
* <param name="colour">The colour the ClientMessage is</param>
* <param name="color">The colour the ClientMessage is</param>
* <param name="text">The actual message</param>
* <seealso name="OnPlayerText" />
* <remarks>This NPC callback was added in <b>SA-MP 0.3a</b> and will not work in earlier versions!</remarks>
*/
forward OnClientMessage(colour, text[]);
forward OnClientMessage(color, text[]);

/**
* <summary>Just as the player version of the callback, this callback is called when any player dies.</summary>
Expand Down