Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics for detection of endless loops #634

Merged
merged 11 commits into from
May 2, 2021
Merged

Diagnostics for detection of endless loops #634

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
355b324
Skip warning ID 249
Daniel-Cortez Jan 30, 2021
0b721bf
Reformat struct "assigninfo" into "symstate", so it could be used to …
Daniel-Cortez Oct 17, 2020
e0cde05
Warn when variables used inside of a loop condition aren't modified i…
Daniel-Cortez Oct 7, 2020
7d1b6c9
Disable the new diagnostics when a function or an array is used insid…
Daniel-Cortez Oct 18, 2020
ae30cfb
Add tests
Daniel-Cortez Oct 18, 2020
bff0307
Disable warnings 250 and 251 when a global variable is used inside a …
Daniel-Cortez Jan 30, 2021
59c6de1
Update tests
Daniel-Cortez Jan 30, 2021
48c1079
Don't count function arguments passed by const reference as modified
Daniel-Cortez Jan 31, 2021
e137b1c
Add two more test cases to make sure passed-by-reference function arg…
Daniel-Cortez Jan 31, 2021
1951308
Make the new diagnostics actually work on `do-while` loops
Daniel-Cortez Jan 31, 2021
64b2cda
Update tests
Daniel-Cortez Jan 31, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't count function arguments passed by const reference as modified
  • Loading branch information
@Daniel-Cortez
Daniel-Cortez committed May 2, 2021
commit 48c10791dbde8ccd3b9d05dc823035272976d461
4 changes: 2 additions & 2 deletions source/compiler/sc3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2402,9 +2402,9 @@ static int nesting=0;
check_tagmismatch_multiple(arg[argidx].tags,arg[argidx].numtags,lval.tag,-1);
if (lval.tag!=0)
append_constval(&taglst,arg[argidx].name,lval.tag,0);
argidx++; /* argument done */
if (lval.sym!=NULL)
if (lval.sym!=NULL && (arg[argidx].usage & uCONST)==0)
markusage(lval.sym,uWRITTEN);
argidx++; /* argument done */
break;
case iREFARRAY:
if (lval.ident!=iARRAY && lval.ident!=iREFARRAY
Expand Down