feature(53): Remove unused service from pkg/pathfinder

pawelWritesCode · Oct 1, 2023 · d0b93b1 · d0b93b1
1 parent 0bc216b
commit d0b93b1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 68 deletions.
diff --git a/pkg/pathfinder/jsonpath.go b/pkg/pathfinder/jsonpath.go
@@ -8,13 +8,9 @@ import (
 
 	"github.com/antchfx/jsonquery"
 	"github.com/oliveagle/jsonpath"
-	"github.com/pawelWritesCode/qjson"
 	"github.com/tidwall/gjson"
 )
 
-// QJSONFinder represents implementation of JSON path from https://github.com/pawelWritesCode/qjson library
-type QJSONFinder struct{}
-
 // OliveagleJSONFinder represents implementation of JSON path from https://github.com/oliveagle/jsonpath library
 type OliveagleJSONFinder struct{}
 
@@ -33,10 +29,6 @@ type DynamicJSONPathFinder struct {
 	antchfxJSONQuery    AntchfxJSONQueryFinder
 }
 
-func NewQJSONFinder() QJSONFinder {
-	return QJSONFinder{}
-}
-
 func NewOliveagleJSONFinder() OliveagleJSONFinder {
 	return OliveagleJSONFinder{}
 }
@@ -53,11 +45,6 @@ func NewDynamicJSONPathFinder(gjson GJSONFinder, oliveagleJSONFinder OliveagleJS
 	return &DynamicJSONPathFinder{gjson: gjson, oliveagleJSONFinder: oliveagleJSONFinder, antchfxJSONQuery: antchfxJSONQuery}
 }
 
-// Find obtains data from jsonBytes according to given expr valid with pawelWritesCode/qjson library
-func (Q QJSONFinder) Find(expr string, jsonBytes []byte) (any, error) {
-	return qjson.Resolve(expr, jsonBytes)
-}
-
 // Find obtains data from jsonBytes according to given expr.
 // It accepts expr in format acceptable by tidwall/gjson, oliveagle/jsonpath or antchfx/jsonquery libraries.
 func (d DynamicJSONPathFinder) Find(expr string, jsonBytes []byte) (any, error) {

diff --git a/pkg/pathfinder/jsonpath_test.go b/pkg/pathfinder/jsonpath_test.go
@@ -47,61 +47,6 @@ var jsonBytes = []byte(`{
     "expensive": 10
 }`)
 
-func TestQJSONFinder_Find(t *testing.T) {
-	type args struct {
-		expr      string
-		jsonBytes []byte
-	}
-	tests := []struct {
-		name    string
-		args    args
-		want    any
-		wantErr bool
-	}{
-		{name: "no expression", args: args{
-			expr:      "",
-			jsonBytes: []byte(""),
-		}, want: nil, wantErr: true},
-		{name: "no jsonBytes", args: args{
-			expr:      "data",
-			jsonBytes: []byte(""),
-		}, want: nil, wantErr: true},
-		{name: "expression points to nothing", args: args{
-			expr:      "data",
-			jsonBytes: jsonBytes,
-		}, want: nil, wantErr: true},
-		{name: "successful fetch data #1", args: args{
-			expr:      "store.book[0].category",
-			jsonBytes: jsonBytes,
-		}, want: any("reference"), wantErr: false},
-		{name: "successful fetch data #2", args: args{
-			expr:      "store.book[1].price",
-			jsonBytes: jsonBytes,
-		}, want: any(float64(12.99)), wantErr: false},
-		{name: "successful fetch data #3", args: args{
-			expr:      "store.book[2].available",
-			jsonBytes: jsonBytes,
-		}, want: any(true), wantErr: false},
-		{name: "successful fetch data #4", args: args{
-			expr:      "store.bicycle",
-			jsonBytes: jsonBytes,
-		}, want: any(map[string]any{"color": "red", "price": float64(19.95)}), wantErr: false},
-	}
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			Q := QJSONFinder{}
-			got, err := Q.Find(tt.args.expr, tt.args.jsonBytes)
-			if (err != nil) != tt.wantErr {
-				t.Errorf("Find() error = %v, wantErr %v", err, tt.wantErr)
-				return
-			}
-			if !reflect.DeepEqual(got, tt.want) {
-				t.Errorf("Find() got = %v, want %v", got, tt.want)
-			}
-		})
-	}
-}
-
 func TestOliveagleJSONFInder_Find(t *testing.T) {
 	type args struct {
 		expr      string