Skip to content

Update dependencies and separate server imports #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update dependencies and separate server imports #71

wants to merge 2 commits into from

Conversation

pavtiger
Copy link
Owner

@pavtiger pavtiger commented Jun 9, 2023

Fixes #65

@pavtiger
Copy link
Owner Author

pavtiger commented Jun 9, 2023

To validate that all library requirements are met and code works I used this command docker run -it -v /home/pavtiger/Docs/Parse-tables-from-PDF:/home/pavtiger/Docs/Parse-tables-from-PDF --entrypoint "/bin/bash" -p 1303:1303 ubuntu:22.04 to create a fresh docker container

No-name-and-surname
No-name-and-surname reviewed Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@No-name-and-surname No-name-and-surname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find any gross mistakes here)
I had only one question.

recognise.py
if quality < 200:
print('Quality is set to a number smaller than 200. THis is highly unadvised and '
if quality < 4:
print('Quality is set to a number smaller than 4. This is highly unadvised and '
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use ''' here, I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@No-name-and-surname No-name-and-surname No-name-and-surname left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local execution fails without optional libraries for the webserver
2 participants
@pavtiger @No-name-and-surname