Skip to content

Accept different HTTP request methods#33

Merged
pavlakis merged 11 commits into
masterfrom
develop
Oct 23, 2019
Merged

Accept different HTTP request methods#33
pavlakis merged 11 commits into
masterfrom
develop

Conversation

@pavlakis

@pavlakis pavlakis commented Oct 23, 2019

Copy link
Copy Markdown
Owner
  • Introduced an interface for EnvironmentPropertiesInterface to decouple EnvironmentProperties
  • Can now accept different HTTP request methods by using a RequestInterface
  • Documentation has been updated to follow ThePHPLeague skeleton

Backwards compatibility has been maintained. If no dependencies are passed, the defaults are loaded.

Antonios Pavlakis and others added 11 commits February 18, 2018 21:14
* Add phpstan static analysis

* Inject additional environment properties as required

Remove composer lock file

Get mock request through a private method

Update copyright and fix formatting

PHP CS formatting
* Add option to pass additional environment properties (#20)

 Inject additional environment properties as required

* Update travis to run static analysis only for PHP 7.2 (#22)

* Remove phpstan from composer

* Static analysis with PHPStan (#23)

Add phpstan for PHP 7.2

Add phpstan badge
* Add coding standards

* Align Readme formatting with The PHP League skeleton Readme

* Add PHP 7.3 to travis and run coding standards

* Add a supported PHP CS Fixer version (2.2) for legacy PHP 5.5

* Remove @coversNothing PhpUnit annotation
@codecov-io

codecov-io commented Oct 23, 2019

Copy link
Copy Markdown

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #33   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      3    +1     
  Lines          54     60    +6     
=====================================
+ Hits           54     60    +6
Impacted Files Coverage Δ
src/Request/Request.php 100% <100%> (ø)
src/Environment/EnvironmentProperties.php 100% <100%> (ø) ⬆️
src/CliRequest.php 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb02c0...274d297. Read the comment docs.

@pavlakis pavlakis merged commit 5232adc into master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants