Skip to content

Fully generalization Module Ann to Module a #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

opyapeus
Copy link
Contributor

@opyapeus opyapeus commented Jun 9, 2020

The title is as it is.
Please let me know so that I can fix any concerns.

Motivation for this PR

When I tried to understand how CoreFn works, I thought it would be better to read without annotations.

By generalizing Ann, it became easier to read by applying VoidAnn, for example.

And like this commit, it may be a good idea to write a test module in the test code itself.

P.S. Thanks for merging my previous PR!

@opyapeus opyapeus changed the title Generalize Module Ann to Module a Fully generalization Module Ann to Module a Jun 9, 2020
@paulyoung
Copy link
Owner

paulyoung commented Jun 11, 2020

I’ll try to take a look at this soon.

As mentioned here, in the past I’ve tried to keep this as close to the Haskell implementation as possible.

@opyapeus
Copy link
Contributor Author

I agreed with your thought.
It’s better to submit this changes to the Purescript repo first.
So please put this PR on hold now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants