chore: Unified Sidebar menu collection using a sidebar loader #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think static sidebar in every html looks good if user opens the file directly to web explorers. Yet this not only introduces tons of repetative code, but also requires heavy workload on maintainance work like updating since every html needs to be updated if new functionly html needs to be added or removed.
Instead, reading menu code from a single
nav.html
to form a dynamic sidebar could be more efficient. Also this may be more convenient for people who want to get this project translated (i18n issue).Example pages just work fine:
Now here is the issue:
when user directly open any of the htmls from their double clicks, menu wont be shown due to mismatch of
nav.html
relative path.To solve this, one must use
python3 -m http.server 8080
underdocs
and openhttp://localhost:8080
on their browser as a local website.