updated getTrustedHeaderNames to return without setting $this->headers

paulredmond · Jan 10, 2019 · 207af4b · 207af4b
1 parent 44fa335
commit 207af4b
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/TrustProxies.php b/src/TrustProxies.php
@@ -113,16 +113,17 @@ protected function getTrustedHeaderNames()
         switch ($headers) {
             case 'HEADER_X_FORWARDED_AWS_ELB':
             case Request::HEADER_X_FORWARDED_AWS_ELB:
-                $this->headers = Request::HEADER_X_FORWARDED_AWS_ELB;
+                return Request::HEADER_X_FORWARDED_AWS_ELB;
                 break;
             case 'HEADER_FORWARDED':
             case Request::HEADER_FORWARDED:
-                $this->headers = Request::HEADER_FORWARDED;
+                return Request::HEADER_FORWARDED;
                 break;
             default:
-                $this->headers = Request::HEADER_X_FORWARDED_ALL;
+                return Request::HEADER_X_FORWARDED_ALL;
         }
 
-        return $this->headers;
+        // Should never reach this point
+        return $headers;
     }
 }