Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is everything needed to convert the project to .NET Standard 2.0. I did this because I'd like to use this in another project of mine but it does not support .NET Framework.
.NET Standard 2.0 is the last .NET Standard release to support the .NET Framework targets so compatibility with those who are using the project now should be maintained so long as they are on .NET Framework 4.6.1 or later.
https://docs.microsoft.com/en-us/dotnet/standard/net-standard
Part of the migration required pulling out the Should library dependency and replacing it with the mostly compatible Shouldly library. This require a change of
ShouldEqual
toShouldBe
.NSubstitute was also removed, it did not appear to be in use and all tests are passing without it's presence.
I changed
resp.Headers[0].Name.ShouldEqual("ThisHeader");
andresp.Headers[0].Value.ShouldEqual("ThisValue");
toresp.Headers[1].Name.ShouldEqual("ThisHeader");
andresp.Headers[1].Value.ShouldEqual("ThisValue");
in order to fix a test that was failing. It appears the first header wasn't what was expected but the second header was. I'm not sure if this is a breaking change in any way.I've updated the appveyor.yml file to what I believe should work for these changes but I do not have any way that I am aware of to test it myself.
Let me know if there is anything I should change or if you have any issues with this pull request.
Thanks!