Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with handling the TAP_BIP32_DERIVATION field. #101

Closed
cmdruid opened this issue Jul 10, 2024 · 3 comments
Closed

Issues with handling the TAP_BIP32_DERIVATION field. #101

cmdruid opened this issue Jul 10, 2024 · 3 comments

Comments

@cmdruid
Copy link

cmdruid commented Jul 10, 2024

Hello I am running into issues when the TAP_BIP32_DERIVATION field is included within a PSBT.

I understand that this library does not support using the TAP_BIP32_DERIVATION field when the library is used for signing.

However, other wallets use this field for signing, and this library should not fail during signing when the field is present, it should simply ignore the field.

Another issue is that once a signature is present for a PSBT input, this library will not let you remove the TAP_BIP32_DERIVATION field. So you can't avoid the library failing during signing, you are simply doomed.

I feel like this can be handled better. The easiest fix would be to ignore the field, and not blow up.

@paulmillr
Copy link
Owner

Ignoring it will make the library produce different outputs for the same psbt, from other libraries.

@cmdruid
Copy link
Author

cmdruid commented Jul 13, 2024

Can you elaborate on this?

How does another library that does not sign for that input have any effect?

@paulmillr
Copy link
Owner

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants