Always check arguments length before pulling from it #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmillr
added a commit
that referenced
this pull request
Dec 19, 2013
Always check arguments length before pulling from it
Why not? They’re just tests. How else are you gonna verify this patch works correctly? |
|
@mathiasbynens feel free submit them in a PR, but I'm mostly OK with just saying "modifying the Object prototype is not supported" :-p |
Then why bother with this patch? |
|
You raise good points. PR coming. |
|
Already done: #179. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175. I intentionally did not add tests because I don't want to modify Object.prototype at all, however temporarily.