Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports AWS Code Commit. #128

Merged
merged 5 commits into from
Aug 16, 2018
Merged

Supports AWS Code Commit. #128

merged 5 commits into from
Aug 16, 2018

Conversation

crossroad0201
Copy link
Contributor

Added support for the AWS Code Commit.

Thank you.

@derimagia
Copy link
Collaborator

Thanks!

Would appreciate it if you're able to write tests for this. Otherwise we'll get around to it

@crossroad0201
Copy link
Contributor Author

crossroad0201 commented Aug 9, 2018

OK!
I will add test cases 👍

@crossroad0201
Copy link
Contributor Author

@derimagia
I added tests.
Please check that.

git-open Outdated
@@ -198,6 +198,11 @@ elif [[ "${#pathargs[@]}" -ge '2' && ${pathargs[${#pathargs[@]} - 2]} == '_git'
fi
elif [[ "$domain" =~ amazonaws\.com$ ]]; then
# AWS Code Commit
if (( is_issue )); then
echo "Issue feature does not supported on AWS Code Commit." 1>&2
exit 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the Indentation here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry...
I fixed it.

@derimagia derimagia merged commit 5fefffe into paulirish:master Aug 16, 2018
@derimagia derimagia mentioned this pull request Aug 16, 2018
iblea pushed a commit to iblea/git-open that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants