Add configurable name to the error #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,11 @@ def update | |||
| if failures.empty? | |||
| redirect_to(action: :show, :notice => "Changes successfully updated") | |||
| else | |||
| flash[:error] = failures.flat_map(&:errors).flat_map(&:full_messages).join(',') | |||
| flash[:error] = failures.map { |c| [c, c.errors] }.flat_map { |c, e| | |||
There was a problem hiding this comment.
can you add a test for this behavior? Then happy to merge. Also: miss u
There was a problem hiding this comment.
You maintain this gem?! I missed that. And you 💙
The spec would need to be inside feature, right? Because I don't see plain controller specs in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a value with an invalid type the flash[:error] message only says "invalid value" (or whatever is stated in
activerecord.errors.messages.invalidi18n). There is no contextual information for the user regarding which configurable is failing.This PR addresses that by prefixing the message with the configurable name.
Another alternative would be add a custom i18n friendly error key for this. But I didn't want to introduce more than what was needed.