fix: add missing extensions and correct UID defaults for pre-built images #48
Conversation
…ages Fixes #43: Pre-built images use UID 999 - Update .env.example to default POSTGRES_UID/GID to 999 (matches pre-built images) - Document UID/GID requirements in README for pre-built vs local builds - Add validation for PG_EFFECTIVE_IO_CONCURRENCY (clamp to max 1000) Fixes #47: Add missing contrib extensions - Add cube, earthdistance, intarray, ltree, pg_prewarm, tablefunc, unaccent - Update pgtap smoke tests to verify new extensions (plan count 29 → 36) - Document new extensions in README extension bundle section 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello @paudley, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves two key issues: standardizing user/group IDs for pre-built container images and expanding the set of default PostgreSQL extensions. It ensures consistent UID/GID settings in Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
paudley
added
bug
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the default UID/GID for pre-built images to 999 and adds several new PostgreSQL extensions to the core list. The documentation and tests have been updated accordingly. My review includes two suggestions for improvement: one to enhance configuration validation by adding a lower-bound check for PG_EFFECTIVE_IO_CONCURRENCY, and another to sort the list of extensions alphabetically for better maintainability.
There was a problem hiding this comment.
Pull request overview
This PR fixes two issues: corrects UID/GID defaults for pre-built images (which use UID/GID 999, not the host UID), and adds 7 missing PostgreSQL contrib extensions to the core extension bundle. The changes ensure pre-built images work out-of-the-box and expand the available database functionality with commonly-used extensions for spatial calculations, array operations, hierarchical data, and text processing.
Key changes:
- Updated
.env.exampleand README to document that pre-built images requirePOSTGRES_UID/GID=999 - Added 7 contrib extensions:
cube,earthdistance,intarray,ltree,pg_prewarm,tablefunc,unaccent - Added configuration validation to clamp
PG_EFFECTIVE_IO_CONCURRENCYto PostgreSQL's max value of 1000
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/lib/extensions_list.sh |
Adds 7 new contrib extensions to CORE_EXTENSION_LIST with dependency ordering |
scripts/lib/extensions.sh |
Updates pgtap smoke test plan from 29 to 36 and adds tests for new extensions |
postgres/initdb/00-render-config.sh |
Adds validation to clamp PG_EFFECTIVE_IO_CONCURRENCY above 1000 to max value |
README.md |
Documents UID/GID requirements for pre-built images and updates extension bundle lists |
.env.example |
Sets POSTGRES_UID/GID defaults to 999 with explanatory comments |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Addresses PR review feedback - bloom was already in CORE_EXTENSION_LIST but missing from the documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add bloom extension to README documentation - Add negative value check for PG_EFFECTIVE_IO_CONCURRENCY (clamp to 0) - Add missing bloom and pg_cron tests to pgtap smoke - Fix test plan count (36 → 39) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 participant
Summary
Changes
Issue #43: UID/GID Configuration
.env.exampleto defaultPOSTGRES_UID/GIDto 999 (matches pre-built ghcr.io images)PG_EFFECTIVE_IO_CONCURRENCYto max 1000Issue #47: Missing Extensions
Added 7 new contrib extensions to
CORE_EXTENSION_LIST:cubeearthdistanceintarrayltreepg_prewarmtablefuncunaccentTest plan
pgtap-smoketo confirm all 36 extension tests passPG_EFFECTIVE_IO_CONCURRENCYclamping works with value > 1000🤖 Generated with Claude Code