Repository navigation
Handle missing product data in stock flows - #1007
Open
exquisiteskink wants to merge 2 commits into
Open
exquisiteskink wants to merge 2 commits into
exquisiteskink wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stock flows can crash or permit invalid transactions when a product name, location, or quantity unit is missing. Handle missing names during sorting and searching, display Unknown for missing locations, and omit an absent location from consume requests so Grocy selects its default. Guard the product overview's unit-dependent prices and stock actions. Consume, purchase, and inventory submissions require a valid stock quantity unit and explain how to repair the product when it is missing.
Fixes #959.
Fixes #833.
Fixes #982.
Validation:
location_idfrom the request; the product overview opened with missing unit data and the transaction displayed a repair message instead of submitting; stock sorting and searching succeeded with a nameless product.:app:testDebugUnitTest :app:assembleDebug :app:lintDebugcompleted successfully; no additional lint findings compared with upstream master.