Repository navigation
Request ACCESS_LOCAL_NETWORK to reach self-hosted servers - #1003
Open
braveheuel wants to merge 1 commit into
Open
braveheuel wants to merge 1 commit into
braveheuel wants to merge 1 commit into
Conversation
* Since targetSdk was lifted to 37 in a3a51f6, Android no longer grants access to the local network implicitly. The permission was never declared, so every request to a self-hosted server on the LAN silently runs into a timeout, which might affect most Grocy installations. * Declare the permission and request it at runtime in two places: on startup when a server is already configured, because existing installations never pass the login again after an update, and in the login flow before the first request. If it is denied, the snackbar offers a shortcut to the app info page, since the system stops showing its dialog after a denial and the permission would otherwise be out of reach. * Tested on a Pixel 8 with Android 17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since targetSdk was lifted to 37 in a3a51f6, Android no longer grants access to the local network implicitly. The permission was never declared, so every request to a self-hosted server on the LAN silently runs into a timeout, which might affect many Grocy installations.
Declare the permission and request it at runtime in two places: on startup when a server is already configured, because existing installations never pass the login again after an update, and in the login flow before the first request. If it is denied, the snackbar offers a shortcut to the app info page, since the system stops showing its dialog after a denial and the permission would otherwise be out of reach.
Tested on a Pixel 8 with Android 17