Fix: invoke onPhoneNumberChange callback with formatted value on init instead of unformatted value from previous state #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of unformatted value from previous state
patw0929
added a commit
that referenced
this pull request
Oct 9, 2019
Bug fixes: * #302: Remove package-lock.json * #283: Fix: invoke onPhoneNumberChange callback with formatted value on init instead of unformatted value from previous state * #300: fixed bug with pasting number over another number * #299: Use cross-env to solve cross platforms issue (scripts with node env variables) Docs: * #298: Update LICENSE * #297: Update README.md * #294: Removed bash highlighting for npm/yarn commands in README
andrewsantarin
pushed a commit
to andrewsantarin/react-intl-tel-input
that referenced
this pull request
Feb 2, 2022
Fix: invoke onPhoneNumberChange callback with formatted value on init instead of unformatted value from previous state
andrewsantarin
pushed a commit
to andrewsantarin/react-intl-tel-input
that referenced
this pull request
Feb 2, 2022
Bug fixes: * patw0929#302: Remove package-lock.json * patw0929#283: Fix: invoke onPhoneNumberChange callback with formatted value on init instead of unformatted value from previous state * patw0929#300: fixed bug with pasting number over another number * patw0929#299: Use cross-env to solve cross platforms issue (scripts with node env variables) Docs: * patw0929#298: Update LICENSE * patw0929#297: Update README.md * patw0929#294: Removed bash highlighting for npm/yarn commands in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
formatOnInitin conjunction withonPhoneNumberChange, a bug causes the latter callback to be invoked with a value from the not-yet-formatted previous state.This change fixes this behavior and notifies the callback with the updated, formatted value.
I have tried to write two test cases (default and
formatOnInit=false), but unfortunately, my knowledge of Enzyme is too limited 😥️ The behavior relies on libphonenumber-js-utils to be done loading, so the test cases must run after the deferred are resolved…Types of changes
Checklist: