fix(LogViewer): Adjust parsed data to remove tab character #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we estimate the height in guessRowHeight, the data we are using has a \t character rather than tabs. This leads to a misleading character count, which impacts the calculated number of rows displayed. Some example data was provided by OpenShift that had overlapping rows. This data had tabs in it. When tabs were removed or replaced with strings, the issue could not be recreated. There may be other issues involved here, but this at least fixes this one provided example. We should talk to products that are continuing to experience this and gather sample outputs to see if we can recreate/adjust on an individual basis.
wise-king-sullyman
approved these changes
Jul 8, 2025
logonoff
reviewed
Jul 8, 2025
| initialIndexWidth, | ||
| useAnsiClasses, | ||
| fastRowHeightEstimationLimit = 5000, | ||
| numSpaces = 8, |
Member
There was a problem hiding this comment.
maybe this info can be fetched from the browser: https://www.w3schools.com/jsref/prop_style_tabsize.asp
Member
Author
There was a problem hiding this comment.
I'm checking with the Core team - I don't think we set this property in PatternFly, but products could definitely do something like this to set numSpaces if they had it set.
Member
Author
There was a problem hiding this comment.
Core says we don't set it, but you should definitely be able to do something like that in OpenShift if you set it there!
|
🎉 This PR is included in version 6.3.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some example data was provided by OpenShift that had overlapping rows. This data had tabs in it. When tabs were removed, the issue went away, leading me to think that this one case is tied to character counts.
When we estimate the height in guessRowHeight, the data we are using has a \t character representing tabs. This leads to a misleading character count, which impacts the calculated number of rows displayed. (2, when we should expect 3, for example).
There may be other issues involved here, but this at least fixes this one provided example. We should talk to products that are continuing to experience this and gather sample outputs to see if we can recreate/adjust on an individual basis.