feat(JumpLinks): warned about href and markup/type updates #575
Conversation
wise-king-sullyman
left a comment
wise-king-sullyman
left a comment
There was a problem hiding this comment.
A couple non-blocking comments
| "emptyState-warn-change-structure", | ||
| "formControls-updated-markup", | ||
| "horizontalSubnav-warn-ariaLabel", | ||
| "jumpLinksItem-warn-prop-markup-updates", |
There was a problem hiding this comment.
I'm not sure if this should really be a warning since the href now being required will throw build errors.
There was a problem hiding this comment.
Yeah that's fair. I'll split that out to its own rule since the markup change should probably still remain a warning.
| @@ -0,0 +1 @@ | |||
| import { JumpLinksItem } from "@patternfly/react-core"; | |||
There was a problem hiding this comment.
Could these tsx files be deleted?
There was a problem hiding this comment.
I think they'd be worth keeping in, just so that running the single tests locally we can still check that the output looks as expected (mainly warning vs error). They might be able to be used to create a mass test file where all the rules' input code is rendered to ensure no rules conflict with one another?
Testing it out, though, the single test command throws an error due to no input/output file being found. The script to build the readme also fails without them.
thatblindgeye
force-pushed
the
iss559_jumpLinks
branch
from
e3232b2 to
c5e7364
Compare
2 participants
Closes #559