Skip to content

Button - support isFavorite and isFavorited on Button for animation styling #853

@jenny-s51

Description

@jenny-s51

Noted by @andrew-ronaldson. The existing implementation of Button in RHOAI does not apply the new variant that supports animations. cc @gitdallas @thatblindgeye

See https://www.patternfly.org/components/button/#favorite

Since this variant is newly supported in PF, RHOAI was a using custom implementation of a Button that uses an icon prop to directly apply favorite icon + styling to the className.

We need a codemod that can check for StarIcon and replace it with the new props for the favorite variant. We can also surface a warning for more complex cases.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Needs triage

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions