feat(react-console): accept random children in AccessConsole component #6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PF4 preview: https://patternfly-react-pr-6374.surge.sh |
KKoukiou
added a commit
to KKoukiou/cockpit-machines
that referenced
this pull request
Sep 29, 2021
KKoukiou
added a commit
to KKoukiou/cockpit-machines
that referenced
this pull request
Sep 29, 2021
pcbailey
reviewed
Sep 29, 2021
So far we were supporting children of three types, SerialConsole, DesktopViewer and VncConsole. This component is consumed by `cockpit machines` product and it's used for exposing consoles of Virtual Machines. A Virtual Machines however can have multiple consoles of one type; for example 2 different serial consoles, something which was not supported until this commit. For this reason we need to extend this component to accept also custom children apart from a single from each from the predefined types. Also start respecting the order of the children to display the options in the AccessConsoles dropdown.
KKoukiou
force-pushed
the
multiple-consoles-of-type
branch
from
da4c82b to
412e5d2
Compare
tlabaj
approved these changes
Oct 19, 2021
redallen
approved these changes
Oct 19, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we were supporting children of three types,
SerialConsole, DesktopViewer and VncConsole.
This component is consumed by
cockpit machinesproduct and it'sused for exposing consoles of Virtual Machines.
A Virtual Machines however can have multiple consoles of one type; for example 2
different serial consoles, something which was not supported until this
commit.
For this reason we need to extend this component to accept also custom
children apart from a single from each from the predefined types.
Also start respecting the order of the children to display the options
in the AccessConsoles dropdown.