-
Notifications
You must be signed in to change notification settings - Fork 376
chore: bump core #12010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump core #12010
Conversation
|
Preview: https://pf-react-pr-12010.surge.sh A11y report: https://pf-react-pr-12010-a11y.surge.sh |
|
@nicolethoen or @dlabaj do you know why this is failing? Looks like this is the error FWIW we have |
22f21f1 to
75c0760
Compare
05bb71e to
7c1f42d
Compare
| "devDependencies": { | ||
| "@babel/core": "^7.24.7", | ||
| "@babel/plugin-transform-modules-commonjs": "^7.24.7", | ||
| "@babel/preset-env": "^7.28.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we have to add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were getting an error about @babel/preset-env not installed with the core bump. @nicolethoen added it, though I stomped her commit and had to redo it 😇 I believe it's a result of some deps updates in core?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah okay. I missed the convo above.
dlabaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
No description provided.