chore(Table): fixed incorrect sorting in table demo #11894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Preview: https://patternfly-react-pr-11894.surge.sh A11y report: https://patternfly-react-pr-11894-a11y.surge.sh |
jenny-s51
suggested changes
Jun 27, 2025
Contributor
jenny-s51
left a comment
jenny-s51
left a comment
There was a problem hiding this comment.
Nice work @melissaing! Tested locally and sorting behavior LGTM. Once you push with the fix to the linting error below this will be all set to merge. 🚀
jenny-s51
approved these changes
Jun 27, 2025
Contributor
There was a problem hiding this comment.
LGTM @melissaing ! Thank you for your contribution and congrats on your first one to Patternfly. 🚀
rebeccaalpert
approved these changes
Jul 11, 2025
Member
|
Should be ok to merge once the big release goes out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #11578. No other table demos seem to have implemented responsive sorting. @jenny-s51