-
Notifications
You must be signed in to change notification settings - Fork 371
chore(chart donut utilization): convert to typescript #11819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(chart donut utilization): convert to typescript #11819
Conversation
Preview: https://patternfly-react-pr-11819.surge.sh A11y report: https://patternfly-react-pr-11819-a11y.surge.sh |
@thatblindgeye ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit for the file/export names: in case we ever added any other utilization charts for non-donut, we could rename these to ChartDonutUtil...
. Not a blocker, though, especially because it could become too verbose for some of these charts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar comment here as your other utilization PR regarding updating the imports/use of hooks and such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just needs a rebase to resolve conflicts otherwise lgtm
f43bbf7
to
d7986fe
Compare
Rebase done. |
Your changes have been released in:
Thanks for your contribution! 🎉 |
* chore(chart donut utilization): convert to typescript * updated usage of hooks
Towards #11719
The following examples of Chart Donut will be converted to TypeScript:
Since there are 18 examples, I'll divide this into 2 PRs making it easier for reviewing.
2nd PR - #11822