Skip to content

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented May 9, 2025

Towards #11719

The following examples of Chart Donut will be converted to TypeScript:

  • Basic
  • Right aligned legend
  • Inverted with right aligned legend
  • Right aligned vertical legend
  • Bottom aligned legend
  • Small
  • Small with right aligned legend
  • Small with bottom aligned subtitle
  • Small with right aligned subtitle

Since there are 18 examples, I'll divide this into 2 PRs making it easier for reviewing.
2nd PR - #11822

@patternfly-build
Copy link
Contributor

patternfly-build commented May 9, 2025

@Mash707
Copy link
Contributor Author

Mash707 commented May 10, 2025

@thatblindgeye ready for review.

@Mash707 Mash707 mentioned this pull request May 9, 2025
18 tasks
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit for the file/export names: in case we ever added any other utilization charts for non-donut, we could rename these to ChartDonutUtil.... Not a blocker, though, especially because it could become too verbose for some of these charts.

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment here as your other utilization PR regarding updating the imports/use of hooks and such.

@Mash707 Mash707 requested a review from thatblindgeye May 14, 2025 18:32
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a rebase to resolve conflicts otherwise lgtm

@Mash707 Mash707 force-pushed the chart-donut-utilization-convert-to-typescript branch from f43bbf7 to d7986fe Compare May 20, 2025 21:08
@Mash707
Copy link
Contributor Author

Mash707 commented May 20, 2025

Rebase done.

@thatblindgeye thatblindgeye merged commit 3be4438 into patternfly:main May 20, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-charts@8.3.0-prerelease.9
  • @patternfly/react-docs@7.3.0-prerelease.18

Thanks for your contribution! 🎉

@Mash707 Mash707 deleted the chart-donut-utilization-convert-to-typescript branch May 21, 2025 19:23
mattnolting pushed a commit to mattnolting/patternfly-react that referenced this pull request Jun 4, 2025
* chore(chart donut utilization): convert to typescript

* updated usage of hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants