Bug - v5 charts - Victory 37.3.4 issues #11355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabrecq
changed the title
dlabrecq
force-pushed
the
v5-victory-fix
branch
from
13d7b80 to
600c53e
Compare
Collaborator
|
Preview: https://patternfly-react-pr-11355.surge.sh A11y report: https://patternfly-react-pr-11355-a11y.surge.sh |
gitdallas
approved these changes
Jan 6, 2025
tlabaj
approved these changes
Jan 7, 2025
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Victory 37.3.4 generates an
props.groupComponent is undefinederror with ourChartBarcomponent. In addition, Victory changed the function signature ofHelpers.getPadding, which generates type errors.Fixes #11354