Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demos): Fixed the broken alert and navigation demos #10286

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

tlabaj
Copy link
Contributor

@tlabaj tlabaj commented Apr 17, 2024

What: Closes #10287

Additional issues:

@patternfly-build
Copy link
Contributor

patternfly-build commented Apr 17, 2024

@@ -12,7 +12,7 @@ import {
Menu,
PageSection
} from '@patternfly/react-core';
import { DashboardHeader } from '@patternfly/react-core/src/demos/DashboardHeader';
import { DashboardHeader } from '@patternfly/react-core/dis/js/demos/DashboardHeader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be dist

@@ -18,7 +18,7 @@ import {
Text
} from '@patternfly/react-core';
import { DashboardBreadcrumb } from '@patternfly/react-core/dist/js/demos/DashboardWrapper';
import { DashboardHeader } from '@patternfly/react-core/src/demos/DashboardHeader';
import { DashboardHeader } from '@patternfly/react-core/dis/js/demos/DashboardHeader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist

@@ -12,7 +12,7 @@ import {
TextContent,
Text
} from '@patternfly/react-core';
import { DashboardHeader } from '@patternfly/react-core/src/demos/DashboardHeader';
import { DashboardHeader } from '@patternfly/react-core/dis/js/demos/DashboardHeader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist

@@ -18,7 +18,7 @@ import {
Text
} from '@patternfly/react-core';
import { DashboardBreadcrumb } from '@patternfly/react-core/dist/js/demos/DashboardWrapper';
import { DashboardHeader } from '@patternfly/react-core/src/demos/DashboardHeader';
import { DashboardHeader } from '@patternfly/react-core/dis/js/demos/DashboardHeader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist

@@ -16,7 +16,7 @@ import {
TextContent,
Text
} from '@patternfly/react-core';
import { DashboardHeader } from '@patternfly/react-core/src/demos/DashboardHeader';
import { DashboardHeader } from '@patternfly/react-core/dis/js/demos/DashboardHeader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist

@@ -15,7 +15,7 @@ import {
Text
} from '@patternfly/react-core';
import { DashboardBreadcrumb } from '@patternfly/react-core/dist/js/demos/DashboardWrapper';
import { DashboardHeader } from '@patternfly/react-core/src/demos/DashboardHeader';
import { DashboardHeader } from '@patternfly/react-core/dis/js/demos/DashboardHeader';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist

Copy link
Contributor

@dlabaj dlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj requested a review from kmcfaul April 17, 2024 19:03
@dlabaj dlabaj merged commit 7476fe4 into patternfly:main Apr 17, 2024
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-code-editor@5.3.0-prerelease.28
  • @patternfly/react-core@5.3.0-prerelease.26
  • @patternfly/react-docs@6.3.0-prerelease.34
  • @patternfly/react-drag-drop@5.3.0-prerelease.26
  • demo-app-ts@5.1.1-prerelease.100
  • @patternfly/react-table@5.3.0-prerelease.28
  • @patternfly/react-templates@1.0.0-prerelease.9

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - [Nav & alert] - broken demoa
4 participants