-
Notifications
You must be signed in to change notification settings - Fork 375
feat(CodeEditor,Divider): consume penta & update core version #10081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview: https://patternfly-react-pr-10081.surge.sh A11y report: https://patternfly-react-pr-10081-a11y.surge.sh |
andrew-ronaldson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merçi!
mcoker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐷👍
mfrances17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #10001, #9919
This bumps the core alpha version to
6.0.0-alpha.84.Adjustments to fix the build:
TreeViewListItemselectablemodifier removed, using a string now.Menufavorite,nav,text,focusmodifiers removed, using a string now.focusshould probably be added back.CalendarMonthprevMonthandnextMonthmodifiers removed, using a string now.The PR updates
CodeEditorwith penta changes, and fixes an example for verticalDividerafter the core-side Divider fix went in.TreeView,Menu,CalendarMonthare not verified other than build fixes.