feat: Remove yarn in favor pnpm #4504
Open
+16,730
−19,530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlabaj
requested review from
rebeccaalpert,
wise-king-sullyman,
nicolethoen,
tlabaj and
kmcfaul
Signed-off-by: Jon Koops <jonkoops@gmail.com>
PR feedback
dlabaj
changed the title
|
Note: This will not build in CI pipeline due to modifications of Github actions. |
nicolethoen
approved these changes
Mar 25, 2025
wise-king-sullyman
requested changes
May 16, 2025
There was a problem hiding this comment.
Attempting to start the dev server or do build locally after doing a clean reinstall of the deps using pnpm results in this error:
/Users/ausulliv/repos/patternfly-org/packages/documentation-site:
ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL patternfly-org@4.21.4 build: `pf-docs-framework build all`
Exit status 2
ELIFECYCLE Command failed with exit code 2.
```
Is this something you see as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR is removing legacy yarn in favor of PNPM. This change will improve the speed along with manageability, readability of patternfly-org. It is still a WIP and should get some input before we move forward with committing this to main.