add contribute/design-guidelines#2075
Conversation
|
PF3 preview: https://patternfly-org-pr-2075-v3.surge.sh/v3 |
redallen
requested review from
abigaeljamie,
gdoyle1,
japhilli-RH and
mmenestr
packages/v4/src/content/contribute/design-guidelines/design-guidelines.md
Outdated
Show resolved
Hide resolved
gdoyle1
left a comment
gdoyle1
left a comment
There was a problem hiding this comment.
@redallen Noticed a couple things...
- Some of the steps on the TOC don't link correctly - step 2 and step 3 and then step 8 and step 9 will highlight the wrong ones
- We do have a visual design request google form out there, @mceledonia is that something we would want to surface on the site rather than sending people directly to me?
abigaeljamie
left a comment
abigaeljamie
left a comment
There was a problem hiding this comment.
Thank you, @redallen !
redallen
force-pushed
the
feat/contributing
branch
from
3e5793f to
4516e11
Compare
|
@gdoyle1 The TOC scrolling should be fixed. It was caused by incorrect offsets (I was using the title header as an offset instead of the masthead's consistent 76px) and images loading (as they load in the height of page changes). |
|
@gdoyle1 @redallen We might want to remove that section completely. We do have the visual design request form, but I believe we want to keep that to internal Red Hat / product teams. I think if a community contribution makes it past the proposal phase we will be already incorporating it into our planning and assigning UX/Visual aid in that way. |
|
@gdoyle1 Per @mceledonia 's suggestion I've removed that paragraph entirely. @mmenestr @abigaeljamie @gdoyle1 Please rereview! |
gdoyle1
left a comment
gdoyle1
left a comment
There was a problem hiding this comment.
Couple other things I found @redallen ! ...
- "When creating high-fidelity mockups, you should first look for existing examples in the PF4-Components Sketch file."
"PF4-Components Sketch file" should be "PatternFly template file" and link here: https://www.sketch.com/s/729c2eee-e8b6-4fcd-8a79-f6faa8c30f89. - The "view source on GitHub" link is broken
|
* add contribute/design-guidelines * update patternfly-next repo to patternfly * fix github link * add responsive-image-loader * use less RAM * revert to webpack-dev-server * update cache dirs * remove section * update link
6 participants
Credit to @japhilli-RH and @abigaeljamie for the content. Taken from their Google drive folder.
Closes #1946