Skip to content

fix(accordion): removing base accordion styles #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brianferry merged 1 commit into from
Nov 2, 2023
Merged

fix(accordion): removing base accordion styles #2643

brianferry merged 1 commit into from
Nov 2, 2023

Conversation

@brianferry
Copy link
Collaborator

@brianferry brianferry commented Nov 1, 2023

#2642

What I did

  1. Remove static styles from base accordion, removed import for pf-accordion.

The pipeline should be fixed with this commit. Base accordion does not contain any style files

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: 145aad1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the functionality Functionality, typically pertaining to the JavaScript. label Nov 1, 2023
@brianferry brianferry linked an issue Nov 1, 2023 that may be closed by this pull request
Error in CI: 'typeof PfAccordion' incorrectly extends base class static side 'typeof BaseAccordion' #2642
Closed
@netlify
Copy link

netlify bot commented Nov 1, 2023 •
edited by github-actions bot
Loading

✅ Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 2745e25
😎 Deploy Preview https://deploy-preview-2643--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Nov 1, 2023
@brianferry brianferry merged commit dc7b07e into main Nov 2, 2023
@brianferry brianferry deleted the fix/accordion/base-class-static branch November 2, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bennypowers bennypowers bennypowers approved these changes

Assignees

No one assigned

Labels

AT passed Automated testing has passed functionality Functionality, typically pertaining to the JavaScript. ready to merge

Projects

Workflow
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error in CI: 'typeof PfAccordion' incorrectly extends base class static side 'typeof BaseAccordion'

3 participants

@brianferry @bennypowers