-
Notifications
You must be signed in to change notification settings - Fork 90
adding how to become a maintainer doc to contributing.md #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding how to become a maintainer doc to contributing.md #736
Conversation
02eed70
to
d932c82
Compare
contributing.md
Outdated
- Encourage and ensure design remains an integral part of the review process and pull in designers for review as needed (you can leverage @patternfly/angular-patternfly-ux if there is no known associated designer). | ||
- Maintain sustained activity versus sporadic. | ||
- Support users and other developers on [PatternFly Slack](https://patternfly.slack.com/) (there is a channel dedicated to Angular Patternfly) and the [mailing list](mailto:patternfly@redhat.com). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dtaylor113 will make that change, @LHinson are there other mailing lists for the other repos that I need to be aware of? I didn't update this for the other ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add the angular-pf ML. The angular ML is pretty much inactive. I'd also include the PF ML since it is more active. None of the other repos have MLs as we didn't want to continue to divide the community as it didn't seem like a successful approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should this be reworded to include both?
(there is a channel dedicated to Angular Patternfly) along with the angular patternfly mailing list and the patternfly mailing list.
or would you prefer to reword it differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Support users and other developers on PatternFly Slack as well as our mailing lists, Angular Patternfly (
mailto:angular-patternfly@redhat.com) and PatternFly (mailto:patternfly@redhat.com).
@LHinson @dtaylor113 changes have been updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
8d606c7
to
9b81604
Compare
added the cross reference to the readme @dtaylor113 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@LHinson, I'm ready to merge this if you are ok with it. -thanks |
Description
This PR introduces a
contributing.md
with documentation on how to become a maintainer with slight modification for Angular PF. This is related to this PR from @LHinson