Skip to content

adding how to become a maintainer doc to contributing.md #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2018

Conversation

amarie401
Copy link
Contributor

@amarie401 amarie401 commented Apr 27, 2018

Description

This PR introduces a contributing.md with documentation on how to become a maintainer with slight modification for Angular PF. This is related to this PR from @LHinson

@amarie401 amarie401 requested review from LHinson and dtaylor113 April 27, 2018 17:23
@amarie401 amarie401 force-pushed the contributing-maintainer branch from 02eed70 to d932c82 Compare April 27, 2018 17:25
LHinson
LHinson previously approved these changes Apr 27, 2018
contributing.md Outdated
- Encourage and ensure design remains an integral part of the review process and pull in designers for review as needed (you can leverage @patternfly/angular-patternfly-ux if there is no known associated designer).
- Maintain sustained activity versus sporadic.
- Support users and other developers on [PatternFly Slack](https://patternfly.slack.com/) (there is a channel dedicated to Angular Patternfly) and the [mailing list](mailto:patternfly@redhat.com).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dtaylor113 will make that change, @LHinson are there other mailing lists for the other repos that I need to be aware of? I didn't update this for the other ones.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add the angular-pf ML. The angular ML is pretty much inactive. I'd also include the PF ML since it is more active. None of the other repos have MLs as we didn't want to continue to divide the community as it didn't seem like a successful approach.

Copy link
Contributor Author

@amarie401 amarie401 Apr 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should this be reworded to include both?

(there is a channel dedicated to Angular Patternfly) along with the angular patternfly mailing list and the patternfly mailing list.

or would you prefer to reword it differently?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amarie401
Copy link
Contributor Author

@LHinson @dtaylor113 changes have been updated

dtaylor113
dtaylor113 previously approved these changes May 1, 2018
Copy link
Member

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dtaylor113
Copy link
Member

Should this contributing doc be cross-referenced in the README.md? We have a Contributing section, we should probably add:
image
It's a little strange that this doc is named 'Contributing' but it really talks about 'Being a Maintainer'

@amarie401 amarie401 force-pushed the contributing-maintainer branch from 8d606c7 to 9b81604 Compare May 1, 2018 15:12
@amarie401
Copy link
Contributor Author

added the cross reference to the readme @dtaylor113 👍

Copy link
Member

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@dtaylor113
Copy link
Member

@LHinson, I'm ready to merge this if you are ok with it. -thanks

@dtaylor113 dtaylor113 merged commit bcf6d0d into patternfly:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants