Coveralls Unit Test Code Coverage #659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
force-pushed
the
coveralls
branch
4 times, most recently
from
e61f33d to
f25bc89
Compare
|
Looking good so far @dtaylor113 Are there any other package.json unit test dependencies we could bring up to date alongside this update, or should we try a separate PR? |
|
Changes Unknown when pulling f25bc89 on dtaylor113:coveralls into ** on patternfly:master**. |
|
I vote for keeping them separate, just so we don't confuse the intention/goal of this PR. |
|
Closing then re-opening to force a build |
|
Changes Unknown when pulling 763d6f2 on dtaylor113:coveralls into ** on patternfly:master**. |
dtaylor113
changed the title
|
I believe this PR is ready to merge. |
cdcabrera
approved these changes
Oct 24, 2017
|
Hi @jeff-phillips-18 can we review this PR and hopefully get it merged so I can verify Coveralls works with Travis for patternfly/angular-patternfly (not just my dtaylor113 fork) -thanks |
jeff-phillips-18
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of the grunt-karma-coveralls plug-in.
Fixes #622
I'm now seeing results :-)
https://coveralls.io/github/patternfly/angular-patternfly