Skip to content

fix(pfWizard): replaced dt with h4 for wizard title #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

jeff-phillips-18
Copy link
Member

@jeff-phillips-18 jeff-phillips-18 commented Oct 19, 2017

Description

For semantic reasons replaced wizard title with an h4 and keep consistent with Patternfly.
Update the wizard close button to sync with changes in PatternFly.

Fixes #653

Copy link
Member

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cdcabrera cdcabrera merged commit db1b797 into patternfly:master Oct 19, 2017
openshift-merge-robot added a commit to openshift/origin-web-console that referenced this pull request Oct 20, 2017
Automatic merge from submit-queue.

Restore port icon with pficon-port

Fixes #2066 

![screen shot 2017-10-20 at 9 17 23 am](https://user-images.githubusercontent.com/895728/31823152-213ae812-b579-11e7-9b94-56f94a1f7aa5.PNG)

And bump angular-patternfly to v4.11.8 to pick up latest [notification
drawer](patternfly/angular-patternfly@dc0491a2) and [wizard](patternfly/angular-patternfly#656) bug fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace dt with h4 for Wizard Title
3 participants