fix(pfNotificationDrawer): Allow setting of the field to use to track notifications #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaylor113
approved these changes
Aug 29, 2017
cdcabrera
approved these changes
Aug 29, 2017
… notifications This will set the ng-repeat’s ‘track by’ value to the given field in the notification.
jeff-phillips-18
force-pushed
the
drawer
branch
from
a554da6 to
32539a1
Compare
| @@ -35,6 +35,7 @@ | |||
| * @param {boolean} drawerExpanded Flag if the drawer is expanded (only valid if allowExpand is true). Optional, default: false | |||
| * @param {string} drawerTitle Title to display for the drawer (leaving this blank will remove the provided expand capability) | |||
| * @param {object} notificationGroups Collection notification groups to add to the drawer. Alternatively, a single group object can be given if categorization is not used. | |||
| * @param {string} notificationTrackField Optional field from the notifications to use to track by in the notifications listing ($index used otherwise). | |||
There was a problem hiding this comment.
I don't know if it matters a ton, but perhaps key instead of field, just for consistency with the lingo Angular uses re: track by. Example:
Duplicates in a repeater are not allowed. Use 'track by' expression to specify unique keys. Repeater: {0}, Duplicate key: {1}, Duplicate value: {2}
From the docs.
|
I see I missed the merge by 1 minute 😄 |
|
Yeah, sorry. If you feel strongly I can update and re-release |
|
I don't think I feel super strong about it, is there anything similar in other components that makes it worth pressing for consistency? |
|
Not that comes to mind. |
|
ok, we prob good to go then! Will be good to pick this up in console +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will set the ng-repeat’s ‘track by’ value to the given field in the notification.
No visual changes.
Reported by openshift/origin-web-console#1981
cc @spadgett @benjaminapetersen