fix(pfFilter): do not allow empty filters #593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
approved these changes
Aug 23, 2017
| @@ -89,7 +89,7 @@ angular.module('patternfly.filters').component('pfFilterFields', { | |||
| } | |||
|
|
|||
| function onValueKeyPress (keyEvent) { | |||
| if (keyEvent.which === 13) { | |||
| if (keyEvent.which === 13 && ctrl.currentValue && ctrl.currentValue.length > 0) { | |||
There was a problem hiding this comment.
Simplify to:
if (keyEvent.which === 13 && ctrl.currentValue.length) {
There was a problem hiding this comment.
@jeff-phillips-18 ctrl.currentValue is set/reset to null so null.length throws an error.
jeff-phillips-18
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated so that hitting [Enter] on an empty input filter field doesn't create an empty filter.
Fixes #509