Skip to content

Fix #37 - Adding support for angular 1.4.x #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2015

Conversation

erundle
Copy link

@erundle erundle commented Sep 2, 2015

Adding support for angular 1.4.x and also changing angular to just be a devDependency since products seem the be specifying their own version anyway and having the listed dependency is causing problems with projects who are trying to consume angular-patternfly via rails-assets since they can't override the version like you can do with bower resolutions.

@waldenraines
Copy link

I get the following when trying to bower install:

Unable to find a suitable version for angular, please choose one:
    1) angular#1.3.18 which resolved to 1.3.18 and is required by angular-animate#1.3.18
    2) angular#1.4.5 which resolved to 1.4.5 and is required by angular-animate#1.4.5, angular-mocks#1.4.5, angular-route#1.4.5, angular-sanitize#1.4.5, angular-touch#1.4.5
    3) angular#1.3.0 - 1.4.* which resolved to 1.4.5 and is required by angular-patternfly

Do we want to add a resolutions section to bower.json for angular?

Note that this only happens when bower installing on an existing set of dependencies (i.e. an upgrade).

@erundle
Copy link
Author

erundle commented Sep 2, 2015

To me the resolutions section would belong in the project that is making the request not in angular-patternfly. Atleast that is how I have done it in the past. This is one of the reasons I am trying to move away from listing angular as an actual dependency, so projects aren't required to have the resolution section.

@dtaylor113
Copy link
Member

LGTM

@waldenraines
Copy link

@erundle makes sense.

waldenraines pushed a commit that referenced this pull request Sep 2, 2015
Fix #37 - Adding support for angular 1.4.x
@waldenraines waldenraines merged commit ae817f5 into patternfly:master Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants