Notification Drawer Updates

[jeff-phillips-18]

Updates to latest Patternfly design pattern from: patternfly/patternfly-design#297
Bumps https://github.com/patternfly/patternfly version to 3.26.0

Fixes #414
Fixes #419
Fixes #420 - Adds documentation on styling for drawer with different navigation layouts
Fixes #421 - Adds a close button to the notification drawer title area
Fixes #430 - Update layout to handle long notification messages
Fixes #429 #432 - Allows a single group to be used thus not using an accordion for groups
Fixes #431 - Displays the pf-empty-state when there are no notifications or none in a particular group. Allows setting the empty message for each.

@benjaminapetersen

[benjaminapetersen]

Great, taking a look!

[benjaminapetersen]

Running grunt serve & noticed the x on the docs file has a shadow:

• fixed! my /lib did not update on my first bower install

[benjaminapetersen]

I also have a scrollable 'empty message' under one of the headings:

• fixed! my /lib did not update on my first bower install

and perhaps a bit constricted? font size is probably good if it fit on two lines:

• fixed! my /lib did not update on my first bower install

[jeff-phillips-18]

@benjaminapetersen Did you update the patternfly version?

[benjaminapetersen]

I did a bower install before grunt serve, which gave me:

$ bower install
bower patternfly#>=3.26.0   not-cached https://github.com/patternfly/patternfly.git#>=3.26.0
bower patternfly#>=3.26.0      resolve https://github.com/patternfly/patternfly.git#>=3.26.0
bower bootstrap-switch#<=3.3.3  cached https://github.com/nostalgiaz/bootstrap-switch.git#3.3.3
bower bootstrap-switch#<=3.3.3         validate 3.3.3 against https://github.com/nostalgiaz/bootstrap-switch.git#<=3.3.3
bower patternfly#>=3.26.0              checkout v3.26.0
bower patternfly#>=3.26.0          invalid-meta The "main" field has to contain only 1 file per filetype; found multiple .css files: ["dist/css/patternfly.css","dist/css/patternfly-additions.css"]
bower patternfly#>=3.26.0              resolved https://github.com/patternfly/patternfly.git#3.26.0
bower bootstrap-switch#<=3.3.3          install bootstrap-switch#3.3.3
bower patternfly#>=3.26.0               install patternfly#3.26.0

[benjaminapetersen]

The empty message definitely helps. Curious if we would want a want to have a single "No notifications" message if all of the tabs are empty. It may annoy a user to open each tab & get the same message over and over:

That may be able to be solved programmatically by updating the notifications-body.html with something like:

<div ng-if="!totalNotificationCount">
   <!-- show a message if there zero notifications -->
</div>
<div ng-if="totalNotificationCount">
   <!-- show the current body -->
</div>

Another possibility might be to provide a new attrib for empty state:

notification-body-include="notification-body.html"
notification-body-empty-include="notification-body-empty.html"

[jeff-phillips-18]

@benjaminapetersen I'd like to leave the 'all groups are empty' issue for further thought and not attempt to address in this PR. I'd like to hear some UX perspectives first.

[benjaminapetersen]

Works for me, I can probably just do the first option in the openshift web console for now.

[jeff-phillips-18]

Feel free to add an issue if you'd like.

[benjaminapetersen]

Ok will do

[cdcabrera]

• Non-breaking alteration code example highlighted...

inline-notification.component.js >> line 107

'pfNotificationRemove': '&?'

[cdcabrera]

Maybe a ===...

[jeff-phillips-18]

Fixed. Thanks.

[cdcabrera]

lgtm