Removed the jquery resolution from bower.json #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is failing with the message:
I tested this locally by using the master branch for patternfly as my dependency, and it worked well. I can time this tomorrow to merge this PR after the patternfly release, but before the angular-patternfly release. Or we can merge it now with the broken bower install. |
|
I think there are some dependencies in the angular-patternfly repo which use jQuery (datatables, bootstrap, bootstrap-datepicker, etc..) which may require the jQuery resolution. |
|
@dtaylor113 This PR undoes the temporary fix I introduced with c12385e. It is no longer necessary as PatternFly 3.24.0 has fixed the underlying problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolution is no longer needed, as patternfly has downgraded the dependency (bootstrap-switch) to a version that no longer brings in this old version of jquery.