change use of patternfly setting functions from '$()' to 'patternfly' #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to help with non-jquery applications
|
Should we consider passing the |
dtaylor113
approved these changes
Feb 15, 2017
|
@bleathem Not all are in IIFE's, I could do it for both that are if you like, or I could put the other in IIFEs as well. Preference? |
|
I suggest doing it for those that are in IFFEs. If other IFFEs don't have it, we can address that in future PRs. |
|
I will do it for all so as not to forget using 'patternfly' for these in the future. |
bleathem
approved these changes
Feb 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to help with non-jquery applications
@dtaylor113 @dgutride @bleathem